feat(toolpath): add meta.kind path-kind field; tag conversation paths "convo"#85
Open
ben-emp wants to merge 2 commits into
Open
feat(toolpath): add meta.kind path-kind field; tag conversation paths "convo"#85ben-emp wants to merge 2 commits into
ben-emp wants to merge 2 commits into
Conversation
… "convo"
New optional `meta.kind` on `Path` (`PathMeta::kind` + the
`PATH_KIND_CONVERSATION` constant), plumbed through the JSONL form. Every
conversation -> Path derivation now sets `meta.kind = "convo"` — the shared
`toolpath_convo::derive_path` and each conversation provider crate's own.
Documented in the RFC ("Document Kind") and the JSON Schema. Additive; no
version bumps yet.
|
🔍 Preview deployed: https://fbc2d7d0.toolpath.pages.dev |
akesling
approved these changes
May 13, 2026
Contributor
akesling
left a comment
akesling
left a comment
There was a problem hiding this comment.
Update the enum value name and then LGTM. We may also want a kind version and need to follow up with a specification as to what fields go where and why to reflect what we're doing in our transformations and help Claude stay aligned (e.g. we should be able to point Claude at this format spec and have it find bugs, fix things, not paint too much outside the lines).
| unrecognized `kind` should be treated as a generic path. The only value defined | ||
| so far is **`convo`** (future revisions may register more). | ||
|
|
||
| A **`convo`** path is an AI coding conversation. Each conversational-turn step |
Contributor
There was a problem hiding this comment.
Let's call this an "agent-session" or "agent-coding-session" or something that's a bit more self-descriptive. Update the enum name, etc. as well.
Renames the kind value `"convo"` to `"agent-coding-session"` and the constant `PATH_KIND_CONVERSATION` to `PATH_KIND_AGENT_CODING_SESSION`. Updates schema, RFC, CHANGELOG, CLAUDE.md, and all derive crates + tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
meta.kindfield toPath(PathMeta::kind+ aPATH_KIND_CONVERSATIONconstant), so renderers and parsers can recognize a path’s shape. Plumbed through the JSONL form alongsidetitle/source.The one defined value is
"convo", and every conversation →Pathderivation now sets it (the sharedtoolpath_convo::derive_pathand each conversation provider crate). Documented in the RFC ("Document Kind") and the JSON Schema. Additive — existing documents parse and validate unchanged. No version bumps yet.Need help on this PR? Tag
@codesmithwith what you need.